Skip to content

CVE-2026-111497対応/解析環境数の表示追加 - #30

Merged
ikfj merged 10 commits into
RCOSDP:masterfrom
lifematics:master
Nov 10, 2026
Merged

ikfj merged 10 commits into
RCOSDP:masterfrom
lifematics:master

Conversation

@ktanaka85

@ktanaka85 ktanaka85 commented Sep 9, 2026 •

Copy link
Copy Markdown

■解析環境数の表示追加
Binderhubの画面に
あなたは{X}個の解析環境を持っています
という文言のサーバー一覧へのリンクを追加します
https://redmine.devops.rcos.nii.ac.jp/issues/62324

■CVE-2026-111497対応
CVE-2026-111497対応を行ったjupyterhubイメージ(4.1.0-2026.11.06)に変更
nodejsをCVE-2026-111497のサポートパッチがあるv22に変更
https://redmine.devops.rcos.nii.ac.jp/issues/64082

■自動テスト
diffテストのargo-rolloutをv1.9.2に固定
(https://github.com/RCOSDP/CS-binderhub/pull/31で対応されていた以下内容と同事象ですが別テスト)

releases/latest (v1.10系) の CRD が kubectl apply のアノテーションサイズ上限を超えるようになり、tests ジョブが Install Argo Rollouts のステップで失敗していたためです。

@codecov-commenter

codecov-commenter commented Sep 9, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.98%. Comparing base (773c6fb) to head (a7cde85).
⚠️ Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
binderhub/launcher.py 55.55% 4 Missing ⚠️
binderhub/main.py 84.61% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   77.59%   76.98%   -0.62%     
==========================================
  Files          44       44              
  Lines        3616     3693      +77     
  Branches       47       47              
==========================================
+ Hits         2806     2843      +37     
- Misses        785      825      +40     
  Partials       25       25              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ktanaka85

Copy link
Copy Markdown
Author

本改修と関係なく最新のArgo rolloutのアノテーションのサイズがk8sの制限を超えてしまっている模様
自動テストのArgo rolloutのインストール時の問題なのでそちら先に対処します

@ktanaka85 ktanaka85 changed the title 解析環境数の表示追加とhttps://jupyter.cs.rcos.nii.ac.jp/のリンク追加 CVE-2026-111497対応/解析環境数の表示追加 Nov 6, 2026
@ikfj
ikfj merged commit 2146270 into RCOSDP:master Nov 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants